Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1393193004: Add Pool.close(). (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pool@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix semantics. #

Total comments: 4

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -13 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/pool.dart View 1 2 6 chunks +64 lines, -12 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M test/pool_test.dart View 1 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 2 months ago (2015-10-08 23:19:26 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1393193004/diff/20001/lib/pool.dart File lib/pool.dart (right): https://codereview.chromium.org/1393193004/diff/20001/lib/pool.dart#newcode109 lib/pool.dart:109: return request().then((resource) { Use async/await? https://codereview.chromium.org/1393193004/diff/20001/lib/pool.dart#newcode124 lib/pool.dart:124: if ...
5 years, 2 months ago (2015-10-09 00:25:25 UTC) #2
nweiz
Code review changes
5 years, 2 months ago (2015-10-09 00:46:14 UTC) #3
nweiz
https://codereview.chromium.org/1393193004/diff/20001/lib/pool.dart File lib/pool.dart (right): https://codereview.chromium.org/1393193004/diff/20001/lib/pool.dart#newcode109 lib/pool.dart:109: return request().then((resource) { On 2015/10/09 00:25:25, Bob Nystrom wrote: ...
5 years, 2 months ago (2015-10-09 00:46:20 UTC) #4
nweiz
5 years, 2 months ago (2015-10-09 00:46:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
30410bf531796a7ffdef64fd7953df7b6354bb3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698