Issue 13927008: Align start of the page's object area to match OS::kMaxPreferredCodeAlignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13927008: Align start of the page's object area to match OS::kMaxPreferredCodeAlignment. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Align start of the page's object area to match OS::kMaxPreferredCodeAlignment. On ia32 we were aligning it only by 8 bytes which would later negate all our attemps to align code objects by 16 or 32 bytes as the very first code object would be misaligned and the rest would have the same misalignment modulo preferred code alignment. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21269

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/pages.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

Please take a look. This is mostly performance neutral but at least we now get ...

7 years, 8 months ago (2013-04-10 20:07:53 UTC) #1

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-11 11:47:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21269 (presubmit successful).

Expand Messages | Collapse Messages