dartfmt line wrapping bypass option support.

dartfmt line wrapping bypass option support.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32034

[Brian Wilkerson, 2014-01-27 20:14:50]

LGTM

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/writer.dart:293: if (maxLineLength > -1) {
Will the SimpleLineBreaker work if the line length is zero? If not, consider
changing the test to "maxLineLength > 0".

[lukechurch, 2014-01-27 20:39:44]

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/bin/formatter.dart
File pkg/analyzer/bin/formatter.dart (right):

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/bin/formatter.d...
pkg/analyzer/bin/formatter.dart:81: if (lengthOption.toUpperCase() == 'INF') {
I would recommend also supporting INFINITY - to support the use case of people
using the expanded form of the command line args.

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/writer.dart:293: if (maxLineLength > -1) {
On 2014/01/27 20:14:50, Brian Wilkerson wrote:
> Will the SimpleLineBreaker work if the line length is zero? If not, consider
> changing the test to "maxLineLength > 0".

I agree (+1 seems loaded in this context ;))

Zero should be supported to also disable the line breaker

[pquitslund, 2014-01-27 22:23:37]

Thanks!

(FWIW Added test updates too with a minor fix.)

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/bin/formatter.dart
File pkg/analyzer/bin/formatter.dart (right):

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/bin/formatter.d...
pkg/analyzer/bin/formatter.dart:81: if (lengthOption.toUpperCase() == 'INF') {
On 2014/01/27 20:39:44, lukechurch wrote:
> I would recommend also supporting INFINITY - to support the use case of people
> using the expanded form of the command line args.

Done.

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/writer.dart:293: if (maxLineLength > -1) {
On 2014/01/27 20:14:50, Brian Wilkerson wrote:
> Will the SimpleLineBreaker work if the line length is zero? If not, consider
> changing the test to "maxLineLength > 0".

Good call.  Done!

https://codereview.chromium.org/139263011/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/writer.dart:293: if (maxLineLength > -1) {
On 2014/01/27 20:39:44, lukechurch wrote:
> On 2014/01/27 20:14:50, Brian Wilkerson wrote:
> > Will the SimpleLineBreaker work if the line length is zero? If not, consider
> > changing the test to "maxLineLength > 0".
> 
> I agree (+1 seems loaded in this context ;))
> 
> Zero should be supported to also disable the line breaker

Done.

[pquitslund, 2014-01-27 22:23:58]

Committed patchset #3 manually as r32034 (presubmit successful).