Issue 13925024: Implements write barrier on MIPS.

Issue 13925024: Implements write barrier on MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implements write barrier on MIPS. Committed: https://code.google.com/p/dart/source/detail?r=21532

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -15 lines)			Patch
M	runtime/vm/assembler_mips.h	View		3 chunks	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1	2 chunks	+155 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		1 chunk	+51 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/13925024/diff/1/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/13925024/diff/1/runtime/vm/assembler_mips.cc#newcode461 runtime/vm/assembler_mips.cc:461: // ------------- I would add a TODO to ...

7 years, 8 months ago (2013-04-16 00:16:38 UTC) #2

zra

Thanks! https://codereview.chromium.org/13925024/diff/1/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/13925024/diff/1/runtime/vm/assembler_mips.cc#newcode461 runtime/vm/assembler_mips.cc:461: // ------------- On 2013/04/16 00:16:38, regis wrote: > ...

7 years, 8 months ago (2013-04-16 00:24:42 UTC) #3

zra

7 years, 8 months ago (2013-04-16 00:25:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21532 (presubmit successful).

Expand Messages | Collapse Messages