Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 13919004: Make only_in_release_mode read the environment variable directly. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
ricow1, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make only_in_release_mode read the environment variable directly. BUG=http://dartbug.com/9821 Committed: https://code.google.com/p/dart/source/detail?r=21211

Patch Set 1 #

Patch Set 2 : Don't overwrite the script itself. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M dart/tools/only_in_release_mode.py View 1 1 chunk +16 lines, -23 lines 0 comments Download
M dart/utils/apidoc/apidoc.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
7 years, 8 months ago (2013-04-10 15:12:42 UTC) #1
kustermann
lgtm
7 years, 8 months ago (2013-04-10 15:20:13 UTC) #2
ahe
7 years, 8 months ago (2013-04-10 15:44:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698