Add support for proxies requiing authentication

Add support for proxies requiing authentication

R=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=5468

Committed: https://code.google.com/p/dart/source/detail?r=21417

[Anders Johnsen, 2013-04-15 07:07:19]

LGTM

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http.dart#newcode980
sdk/lib/io/http.dart:980: * authentication. The proxy used and and the security
realm from
double 'and'. Rewrite first part of the sentence.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:256: List<String> challenge =
headers[HttpHeaders.PROXY_AUTHENTICATE];
Use headers.value? It should do the length == 1 check.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:332: _httpRequest.headers._mutable = true;
Are you sure about this? Don't you want to modify the headers of the new
request? Also, event if, remember to set to false again.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:333: cr.authorize(_httpRequest);
This should be done automatically in _HttpClientRequest.send, right? (of the new
request).

[Søren Gjesse, 2013-04-15 07:42:00]

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http.dart#newcode980
sdk/lib/io/http.dart:980: * authentication. The proxy used and and the security
realm from
On 2013/04/15 07:07:19, Anders Johnsen wrote:
> double 'and'. Rewrite first part of the sentence.

Done.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:256: List<String> challenge =
headers[HttpHeaders.PROXY_AUTHENTICATE];
On 2013/04/15 07:07:19, Anders Johnsen wrote:
> Use headers.value? It should do the length == 1 check.

Value throws, and I don't want that here.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:332: _httpRequest.headers._mutable = true;
On 2013/04/15 07:07:19, Anders Johnsen wrote:
> Are you sure about this? Don't you want to modify the headers of the new
> request? Also, event if, remember to set to false again.

Not needed - removed.

https://codereview.chromium.org/13915007/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:333: cr.authorize(_httpRequest);
On 2013/04/15 07:07:19, Anders Johnsen wrote:
> This should be done automatically in _HttpClientRequest.send, right? (of the
new
> request).

Good point - removed.

[Søren Gjesse, 2013-04-15 07:51:47]

Committed patchset #1 manually as r21417 (presubmit successful).