Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13913002: More precise native type for context2D (Closed)

Created:
7 years, 8 months ago by sra1
Modified:
7 years, 8 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More precise native type for context2D Trims 3k off spirodraw Committed: https://code.google.com/p/dart/source/detail?r=21174

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
https://codereview.chromium.org/13913002/diff/1/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate File tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate (right): https://codereview.chromium.org/13913002/diff/1/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate#newcode12 tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate:12: JS('Null|CanvasRenderingContext2D', '#.getContext(#)', this, '2d'); Since this avoids calling the ...
7 years, 8 months ago (2013-04-09 04:14:24 UTC) #1
blois
lgtm
7 years, 8 months ago (2013-04-09 16:04:42 UTC) #2
sra1
7 years, 8 months ago (2013-04-09 22:21:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r21174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698