Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Issue 13912013: Fix issue 9939 by making the body of a try block have two successors: the join block after the try/… (Closed)

Created:
7 years, 8 months ago by ngeoffray
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 9939 by making the body of a try block have two successors: the join block after the try/catch, and the catch (or finally) block. Committed: https://code.google.com/p/dart/source/detail?r=21618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +5 lines, -1 line 0 comments Download
A tests/language/issue9939_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 8 months ago (2013-04-17 11:42:32 UTC) #1
ngeoffray
7 years, 8 months ago (2013-04-17 11:57:38 UTC) #2
Johnni Winther
lgtm
7 years, 8 months ago (2013-04-17 12:27:45 UTC) #3
ngeoffray
7 years, 8 months ago (2013-04-17 12:30:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698