Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Issue 13912003: Realize that this() is a closure send. (Closed)

Created:
7 years, 8 months ago by ngeoffray
Modified:
7 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Realize that this() is a closure send. Committed: https://code.google.com/p/dart/source/detail?r=21204

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +4 lines, -1 line 0 comments Download
A tests/language/call_this_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
7 years, 8 months ago (2013-04-10 13:46:37 UTC) #1
ahe
LGTM!
7 years, 8 months ago (2013-04-10 13:58:14 UTC) #2
ahe
Remember to update the status file.
7 years, 8 months ago (2013-04-10 13:58:29 UTC) #3
ngeoffray
On 2013/04/10 13:58:29, ahe wrote: > Remember to update the status file. Done.
7 years, 8 months ago (2013-04-10 14:04:30 UTC) #4
ngeoffray
7 years, 8 months ago (2013-04-10 14:15:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698