Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1390923006: Fix timing of async test. (Closed)

Created:
5 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 2 months ago
Reviewers:
floitsch, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/async@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix timing of async test. When delayed by other tests, all the values didn't necessarily arrive before they were tested against. BUG= https://github.com/dart-lang/async/issues/4 R=floitsch@google.com Committed: https://github.com/dart-lang/async/commit/59f5b4c4263aa6b06b8f384b7d26e0efbd0620e0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove debug comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M test/subscription_stream_test.dart View 1 3 chunks +25 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 2 months ago (2015-10-12 11:20:58 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1390923006/diff/1/test/subscription_stream_test.dart File test/subscription_stream_test.dart (right): https://codereview.chromium.org/1390923006/diff/1/test/subscription_stream_test.dart#newcode73 test/subscription_stream_test.dart:73: for (var sourceCancels in [/*false,*/ true]) { debug ...
5 years, 2 months ago (2015-10-12 13:18:24 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 59f5b4c4263aa6b06b8f384b7d26e0efbd0620e0 (presubmit successful).
5 years, 2 months ago (2015-10-13 10:37:54 UTC) #4
Lasse Reichstein Nielsen
5 years, 2 months ago (2015-10-13 10:38:21 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1390923006/diff/1/test/subscription_stream_te...
File test/subscription_stream_test.dart (right):

https://codereview.chromium.org/1390923006/diff/1/test/subscription_stream_te...
test/subscription_stream_test.dart:73: for (var sourceCancels in [/*false,*/
true]) {
Yes, removed.

Powered by Google App Engine
This is Rietveld 408576698