Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 139083003: Fix "inherited from" comments for Interceptor (Closed)

Created:
6 years, 11 months ago by Emily Fortuna
Modified:
6 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a snapshot for docgen and use it in the build (https://codereview.chromium.org/116043013/) Also fixed up comments for some inherited object methods. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=31850

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Removed the snapshotting to sdk, just leave the docgen edits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -101 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 3 chunks +3 lines, -5 lines 0 comments Download
A pkg/docgen/doc/README.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
D pkg/docgen/doc/sdk-introduction.md View 1 1 chunk +0 lines, -44 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 23 chunks +110 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
Hey Denmark folk, This is a reincarnation of Alan's CL from here: https://codereview.chromium.org/116043013/ The changes ...
6 years, 11 months ago (2014-01-15 07:21:00 UTC) #1
Emily Fortuna
(removed the snapshotting change in the interest of getting this change in)
6 years, 11 months ago (2014-01-15 18:26:11 UTC) #2
Alan Knight
lgtm
6 years, 11 months ago (2014-01-15 19:13:24 UTC) #3
Emily Fortuna
6 years, 11 months ago (2014-01-15 21:13:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r31850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698