Add a DataUri class.

Add a DataUri class.

This supports encoding and decoding data URIs, using both bytes and
strings.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/http_parser/commit/4ef269538eafda236ddb24e514ebec97acd9cf25

[kevmoo, 2015-10-15 16:05:59]

Suggestion to add this to dart:core – we should align

[kevmoo, 2015-10-19 22:45:21]

start w/ these things...

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart
File lib/src/data_uri.dart (right):

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:137: mediaType ??= new MediaType('text', 'plain');
requires at least dart 1.12, right?

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:283: encoding ??= declaredEncoding;
ditto w/ 1.12 requirement

https://codereview.chromium.org/1390353008/diff/40001/lib/src/scan.dart
File lib/src/scan.dart (right):

https://codereview.chromium.org/1390353008/diff/40001/lib/src/scan.dart#newco...
lib/src/scan.dart:82: var token =
this looks very broken

[nweiz, 2015-10-19 23:08:22]

Code review changes

[nweiz, 2015-10-19 23:08:32]

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart
File lib/src/data_uri.dart (right):

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:137: mediaType ??= new MediaType('text', 'plain');
On 2015/10/19 22:45:21, kevmoo wrote:
> requires at least dart 1.12, right?

Done.

https://codereview.chromium.org/1390353008/diff/40001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:283: encoding ??= declaredEncoding;
On 2015/10/19 22:45:21, kevmoo wrote:
> ditto w/ 1.12 requirement

Done.

https://codereview.chromium.org/1390353008/diff/40001/lib/src/scan.dart
File lib/src/scan.dart (right):

https://codereview.chromium.org/1390353008/diff/40001/lib/src/scan.dart#newco...
lib/src/scan.dart:82: var token =
On 2015/10/19 22:45:21, kevmoo wrote:
> this looks very broken

Done.

[kevmoo, 2015-10-19 23:46:49]

lgtm

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart
File lib/src/data_uri.dart (right):

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:243: 
watch trailing whitespace

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:262: scanner.error("Invalid token.");
I wish 'scanner.error'  returned an error that was thrown here – so the analyzer
knows the function terminates.

Getting a 'no return' warning :-/

[nweiz, 2015-10-20 21:29:22]

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart
File lib/src/data_uri.dart (right):

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:243: 
On 2015/10/19 23:46:49, kevmoo wrote:
> watch trailing whitespace

Done.

https://codereview.chromium.org/1390353008/diff/60001/lib/src/data_uri.dart#n...
lib/src/data_uri.dart:262: scanner.error("Invalid token.");
On 2015/10/19 23:46:49, kevmoo wrote:
> I wish 'scanner.error'  returned an error that was thrown here – so the
analyzer
> knows the function terminates.

I wish there were an @AlwaysThrows annotation that the analyzer knew meant the
function should be treated as a throw.

> Getting a 'no return' warning :-/

Done.

[nweiz, 2015-10-20 21:29:34]

Committed patchset #4 (id:60001) manually as
4ef269538eafda236ddb24e514ebec97acd9cf25 (presubmit successful).