Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 13902009: Improve documentation on address for socket bind (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve documentation on address for socket bind R=ajohnsen@google.com BUG=https://code.google.com/p/dart/issues/detail?id=8410 Committed: https://code.google.com/p/dart/source/detail?r=21545

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M sdk/lib/io/http.dart View 1 1 chunk +16 lines, -4 lines 0 comments Download
M sdk/lib/io/socket.dart View 1 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-16 11:04:02 UTC) #1
Anders Johnsen
LGTM! https://codereview.chromium.org/13902009/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/13902009/diff/1/sdk/lib/io/http.dart#newcode66 sdk/lib/io/http.dart:66: add ' *' https://codereview.chromium.org/13902009/diff/1/sdk/lib/io/http.dart#newcode75 sdk/lib/io/http.dart:75: * retrieved using ...
7 years, 8 months ago (2013-04-16 11:46:23 UTC) #2
Søren Gjesse
https://codereview.chromium.org/13902009/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/13902009/diff/1/sdk/lib/io/http.dart#newcode66 sdk/lib/io/http.dart:66: On 2013/04/16 11:46:23, Anders Johnsen wrote: > add ' ...
7 years, 8 months ago (2013-04-16 12:04:18 UTC) #3
Søren Gjesse
7 years, 8 months ago (2013-04-16 12:05:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698