Add the ability to change the working directory

Add the ability to change the working directory

Directory.current have been changed from a factory constructor to a
getter and setter. The getter returns a Direcotry object holding the
current working directory. The setter changes the current working
directory of the Dart process.

R=whesse@google.com

BUG=https://code.google.com/p/dart/issues/detail?id=6316, https://code.google.com/p/dart/issues/detail?id=8893

Committed: https://code.google.com/p/dart/source/detail?r=22116

[Bill Hesse, 2013-04-29 11:01:12]

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory.cc#newc...
runtime/bin/directory.cc:43: printf("XXX\n");
Remove debug printing.

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory_win.cc
File runtime/bin/directory_win.cc (right):

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory_win.cc#...
runtime/bin/directory_win.cc:430: return SetCurrentDirectoryW(system_path) == 0;
free system_path?

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart
File sdk/lib/io/directory.dart (right):

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart#new...
sdk/lib/io/directory.dart:33: * all running isolates. The value set can be
either a [Directory]
The new value

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart#new...
sdk/lib/io/directory.dart:36: * The value set is passed directly to the
underlying system call
The new value is passed to the OS's system call unchanged, so a relative path
passed as the new working directory will be resolved by the OS.

[Søren Gjesse, 2013-04-29 11:59:15]

PTAL

Addressed review comments and fixed tests

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory.cc#newc...
runtime/bin/directory.cc:43: printf("XXX\n");
On 2013/04/29 11:01:12, Bill Hesse wrote:
> Remove debug printing.

Done.

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory_win.cc
File runtime/bin/directory_win.cc (right):

https://codereview.chromium.org/13896034/diff/1/runtime/bin/directory_win.cc#...
runtime/bin/directory_win.cc:430: return SetCurrentDirectoryW(system_path) == 0;
On 2013/04/29 11:01:12, Bill Hesse wrote:
> free system_path?

Absolutely, thanks

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart
File sdk/lib/io/directory.dart (right):

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart#new...
sdk/lib/io/directory.dart:33: * all running isolates. The value set can be
either a [Directory]
On 2013/04/29 11:01:12, Bill Hesse wrote:
> The new value

Done.

https://codereview.chromium.org/13896034/diff/1/sdk/lib/io/directory.dart#new...
sdk/lib/io/directory.dart:36: * The value set is passed directly to the
underlying system call
On 2013/04/29 11:01:12, Bill Hesse wrote:
> The new value is passed to the OS's system call unchanged, so a relative path
> passed as the new working directory will be resolved by the OS.

Done.

[Bill Hesse, 2013-04-29 12:02:55]

lgtm

[Søren Gjesse, 2013-04-29 12:44:10]

Committed patchset #4 manually as r22116 (presubmit successful).