Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 138953015: Fix bug in DoubleLinkedQueue where removing from empty queue throws. (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in DoubleLinkedQueue where removing from empty queue throws. BUG= http://dartbug.com/16270 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M sdk/lib/collection/queue.dart View 7 chunks +15 lines, -20 lines 0 comments Download
M sdk/lib/core/annotations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/queue_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 11 months ago (2014-01-24 13:13:32 UTC) #1
Anders Johnsen
LGTM!
6 years, 11 months ago (2014-01-27 12:52:06 UTC) #2
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-01-28 09:37:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32060 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698