Issue 13890016: Use checked-in binary to call tools/version.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13890016: Use checked-in binary to call tools/version.dart (Closed)

Created:
7 years, 8 months ago by kustermann

Modified:
7 years, 7 months ago

Reviewers:
ricow1, Søren Gjesse, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use checked-in binary to call tools/version.dart BUG=http://dartbug.com/10193 Committed: https://code.google.com/p/dart/source/detail?r=22033

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	utils/compiler/create_snapshot.dart	View		4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #1 manually as r22033 (presubmit successful).

7 years, 8 months ago (2013-04-25 14:43:29 UTC) #3

ricow1

LGTM I think we want something similar to tools/utils.py for dart scripts that we can ...

7 years, 7 months ago (2013-04-29 07:15:53 UTC) #6

kustermann

7 years, 7 months ago (2013-04-29 08:07:31 UTC) #7

Message was sent while issue was closed.

On 2013/04/29 07:15:53, ricow1 wrote:
> LGTM
> I think we want something similar to tools/utils.py for dart scripts that we
can
> include. That way we have a single (2 with python utils) entry for general
> locations like this.

Yes.

Expand Messages | Collapse Messages