Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 13890015: Removed flaky marker of a number of tests (Closed)

Created:
7 years, 8 months ago by kustermann
Modified:
7 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed flaky marker of a number of tests Most of these tests have stopped crashing after r21356. The v8 bug was fixed in v8:r14190. Since r21629 we use v8 revision v8:r14336 which means that the fix for v8 is now also in our dartium checkouts. BUG=http://dartbug.com/9407 Committed: https://code.google.com/p/dart/source/detail?r=22031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M pkg/pkg.status View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 8 months ago (2013-04-25 13:49:09 UTC) #1
floitsch
LGTM.
7 years, 8 months ago (2013-04-25 13:52:19 UTC) #2
kustermann
7 years, 8 months ago (2013-04-25 13:53:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698