Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 13884017: Adds support for UseDartApi vm test on MIPS. (Closed)

Created:
7 years, 8 months ago by zra
Modified:
7 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds support for UseDartApi vm test on MIPS. Also, adds: - xori instruction, - SubuDetectOverflow (like AdduDetectOverflow). Committed: https://code.google.com/p/dart/source/detail?r=21396

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+781 lines, -38 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_mips.h View 1 2 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/cpu_mips.cc View 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +162 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 9 chunks +456 lines, -24 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 8 months ago (2013-04-12 20:37:16 UTC) #1
regis
LGTM https://codereview.chromium.org/13884017/diff/1/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/13884017/diff/1/runtime/vm/intermediate_language_mips.cc#newcode478 runtime/vm/intermediate_language_mips.cc:478: __ CompareObject(CMPRES, right.reg(), left.constant()); Do you still have ...
7 years, 8 months ago (2013-04-12 21:18:04 UTC) #2
zra
Thanks! https://codereview.chromium.org/13884017/diff/1/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/13884017/diff/1/runtime/vm/intermediate_language_mips.cc#newcode478 runtime/vm/intermediate_language_mips.cc:478: __ CompareObject(CMPRES, right.reg(), left.constant()); On 2013/04/12 21:18:04, regis ...
7 years, 8 months ago (2013-04-12 22:19:59 UTC) #3
zra
7 years, 8 months ago (2013-04-12 22:20:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698