Really fix Dartdoc.

Really fix Dartdoc.

Committed: https://code.google.com/p/dart/source/detail?r=21131

[Andrei Mouravski, 2013-04-09 01:52:40]

lgtm

A few nits.

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:440: return dart2js.analyze(
Why get rid of print message?

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:2151: if (path == null) return
contents;
I'd add a new line after the return contents to make it stand out a bit more as
a terminal condition.

https://codereview.chromium.org/13882002/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/13882002/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:454: Uri _pathToFileUri(String path) {
See previous CL. Put this in a dartdoc/utils and use it.

[nweiz, 2013-04-09 02:10:38]

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:440: return dart2js.analyze(
On 2013/04/09 01:52:40, Andrei Mouravski wrote:
> Why get rid of print message?

Oops, that got removed when I removed a debugging print. I'll put it back.

https://codereview.chromium.org/13882002/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:2151: if (path == null) return
contents;
On 2013/04/09 01:52:40, Andrei Mouravski wrote:
> I'd add a new line after the return contents to make it stand out a bit more
as
> a terminal condition.

Done.

https://codereview.chromium.org/13882002/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/13882002/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:454: Uri _pathToFileUri(String path) {
On 2013/04/09 01:52:40, Andrei Mouravski wrote:
> See previous CL. Put this in a dartdoc/utils and use it.

See reply in previous CL.

[nweiz, 2013-04-09 02:11:25]

Committed patchset #2 manually as r21131 (presubmit successful).