Fix the dartdoc build.

Fix the dartdoc build.

Committed: https://code.google.com/p/dart/source/detail?r=21128

[nweiz, 2013-04-09 01:14:14]

TBR

[nweiz, 2013-04-09 01:14:33]

Committed patchset #1 manually as r21128 (presubmit successful).

[Andrei Mouravski, 2013-04-09 01:48:36]

https://codereview.chromium.org/13878002/diff/1/sdk/lib/_internal/dartdoc/tes...
File sdk/lib/_internal/dartdoc/test/export_map_test.dart (right):

https://codereview.chromium.org/13878002/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/export_map_test.dart:377:
libraries.map(libPath).map(pathToFileUri),
I would put the second map on the next line to be clear about what's happening.
Harder to read in line like this.

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:451: /** Converts a local path string to a `file:`
[Uri]. */
Instead of copypasta, import dartdoc/utils

[Andrei Mouravski, 2013-04-09 01:58:09]

lgtm

[nweiz, 2013-04-09 02:10:23]

https://codereview.chromium.org/13878002/diff/1/sdk/lib/_internal/dartdoc/tes...
File sdk/lib/_internal/dartdoc/test/export_map_test.dart (right):

https://codereview.chromium.org/13878002/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/export_map_test.dart:377:
libraries.map(libPath).map(pathToFileUri),
On 2013/04/09 01:48:36, Andrei Mouravski wrote:
> I would put the second map on the next line to be clear about what's
happening.
> Harder to read in line like this.

Done.

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:451: /** Converts a local path string to a `file:`
[Uri]. */
On 2013/04/09 01:48:36, Andrei Mouravski wrote:
> Instead of copypasta, import dartdoc/utils

I don't like importing utils across projects. It breaks the rule of "don't
import from other projects' src directories", and it makes it hard to tell when
a given utility function is dead.

[Andrei Mouravski, 2013-04-09 02:13:49]

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/13878002/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:451: /** Converts a local path string to a `file:`
[Uri]. */
On 2013/04/09 02:10:23, nweiz wrote:
> On 2013/04/09 01:48:36, Andrei Mouravski wrote:
> > Instead of copypasta, import dartdoc/utils
> 
> I don't like importing utils across projects. It breaks the rule of "don't
> import from other projects' src directories", and it makes it hard to tell
when
> a given utility function is dead.

In which case, putting the function into lib/dartdoc.dart itself would work.