Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 13877006: Add missing functions to ListMixin. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Add missing functions to ListMixin. Were missing: insert, removeAt and expand. BUG= http://dartbug.com/9869 Committed: https://code.google.com/p/dart/source/detail?r=21454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -6 lines) Patch
M sdk/lib/collection/list.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M tests/corelib/iterable_expand_test.dart View 2 chunks +25 lines, -0 lines 0 comments Download
M tests/corelib/list_insert_test.dart View 2 chunks +21 lines, -3 lines 0 comments Download
M tests/corelib/list_removeat_test.dart View 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
Depends on List.setRange change.
7 years, 8 months ago (2013-04-12 22:50:08 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 8 months ago (2013-04-12 22:57:42 UTC) #2
floitsch
7 years, 8 months ago (2013-04-15 14:02:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698