Issue 13877005: Fix invalid SSA graph generated by dart2js by using the savedLocals in a do/while (the ones before …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13877005: Fix invalid SSA graph generated by dart2js by using the savedLocals in a do/while (the ones before … (Closed)

Created:
7 years, 8 months ago by ngeoffray

Modified:
7 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ahe, karlklose

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix invalid SSA graph generated by dart2js in a do/while with breaks, by removing locals that do not exist in all breaks. Committed: https://code.google.com/p/dart/source/detail?r=21271

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
	A	tests/language/do_while4_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/13877005/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/13877005/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode642 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:642: } else { else if?

7 years, 8 months ago (2013-04-11 11:49:49 UTC) #2

ngeoffray

Thanks Kasper! https://codereview.chromium.org/13877005/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/13877005/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode642 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:642: } else { On 2013/04/11 11:49:49, kasperl ...

7 years, 8 months ago (2013-04-11 11:57:48 UTC) #3

ngeoffray

7 years, 8 months ago (2013-04-11 12:10:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21271 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13877005: Fix invalid SSA graph generated by dart2js by using the savedLocals in a do/while (the ones before … (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages