Issue 138723006: Ensure that dart:js does not attempt to load cached proxies from prototypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138723006: Ensure that dart:js does not attempt to load cached proxies from prototypes. (Closed)

Created:
6 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
6 years, 10 months ago

Reviewers:
justinfagnani

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that dart:js does not attempt to load cached proxies from prototypes. dart:js caches proxies on the object itself thus it must guard loading cached proxy from the object with a hasOwnProperty check. R=justinfagnani@google.com BUG=dart:16199 Committed: https://code.google.com/p/dart/source/detail?r=32244

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	sdk/lib/js/dart2js/js_dart2js.dart	View		3 chunks	+9 lines, -2 lines	0 comments	Download
	M	tests/html/js_test.dart	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

justinfagnani

On 2014/01/31 20:11:39, Vyacheslav Egorov wrote: LGTM Thanks for this fix! Can you either add ...

6 years, 10 months ago (2014-01-31 20:27:36 UTC) #2

Vyacheslav Egorov (Chromium)

Thanks for the review. Test added for JS->Dart case, I don't think Dart->JS can occur ...

6 years, 10 months ago (2014-02-03 12:58:13 UTC) #3

Vyacheslav Egorov (Chromium)

6 years, 10 months ago (2014-02-03 13:01:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32244 (presubmit successful).

Expand Messages | Collapse Messages