Issue 13872020: Inline Float32x4 Getters

Issue 13872020: Inline Float32x4 Getters (Closed)

Created:
7 years, 8 months ago by Cutch

Modified:
7 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline Float32x4 Getters Committed: https://code.google.com/p/dart/source/detail?r=21897

Patch Set 5 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -0 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	3 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	4 chunks	+66 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+50 lines, -0 lines	0 comments	Download
M	tests/lib/typed_data/float32x4_unbox_regress_test.dart	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

Do we have tests that test the new functionality? https://codereview.chromium.org/13872020/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/13872020/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1400 runtime/vm/flow_graph_optimizer.cc:1400: ...

7 years, 8 months ago (2013-04-22 22:28:18 UTC) #2

Cutch

Patch Set 2 has explicit test for deopt case with inlined getters. https://codereview.chromium.org/13872020/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc ...

7 years, 8 months ago (2013-04-22 23:05:40 UTC) #3

Cutch

7 years, 8 months ago (2013-04-23 17:52:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r21897 (presubmit successful).

Expand Messages | Collapse Messages