Fix issue with serializing typed array views

Fix issue with serializing typed array views

This makes the code

void isolate() {
  port.receive(print);
}

main() {
  Uint8List list = new Uint8List(1);
  spawnFunction(isolate).send([1, new Uint8List.view(list.buffer, 0, 1)]);
}

not crash.

R=asiva@google.com

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21200

[siva, 2013-04-09 21:15:12]

LGTM

Thanks for taking care of this.

https://codereview.chromium.org/13866012/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/13866012/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:1030: #undef SNAPSHOT_WRITE
Do we need this set of case statements for typedata view classes considering you
have handled them above. I suppose we could remove them as we will fall through
and hit UNREACHABLE().

[Søren Gjesse, 2013-04-10 13:25:20]

https://codereview.chromium.org/13866012/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/13866012/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:1030: #undef SNAPSHOT_WRITE
On 2013/04/09 21:15:12, siva wrote:
> Do we need this set of case statements for typedata view classes considering
you
> have handled them above. I suppose we could remove them as we will fall
through
> and hit UNREACHABLE().

Yes, of cause. Done.

[Søren Gjesse, 2013-04-10 13:42:05]

Committed patchset #2 manually as r21200 (presubmit successful).