Issue 13865004: Fix issue https://code.google.com/p/dart/issues/detail?id=9251, by compiling for/in correctly.

Issue 13865004: Fix issue https://code.google.com/p/dart/issues/detail?id=9251, by compiling for/in correctly. (Closed)

Created:
7 years, 8 months ago by ngeoffray

Modified:
7 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue https://code.google.com/p/dart/issues/detail?id=9251, by compiling for/in correctly. Committed: https://code.google.com/p/dart/source/detail?r=21622

Patch Set 1 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -44 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	2 chunks	+29 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	8 chunks	+14 lines, -17 lines	2 comments	Download
A	tests/language/for_in2_test.dart	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/13865004/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/13865004/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1598 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1598: TypeMask handlePlainAssignment(node, Type?

7 years, 8 months ago (2013-04-17 15:01:12 UTC) #2

ngeoffray

Thanks Peter. https://codereview.chromium.org/13865004/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/13865004/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1598 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1598: TypeMask handlePlainAssignment(node, On 2013/04/17 15:01:12, ahe wrote: ...

7 years, 8 months ago (2013-04-17 15:07:26 UTC) #3

ngeoffray

7 years, 8 months ago (2013-04-17 15:07:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21622 (presubmit successful).

Expand Messages | Collapse Messages