Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 138623002: Enable re-export in docgen. Work in progress. More to come. (Closed)

Created:
6 years, 11 months ago by Emily Fortuna
Modified:
6 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable re-export in docgen. Work in progress. More to come. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=31793

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1462 lines, -1104 lines) Patch
M pkg/barback/lib/barback.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/docgen/bin/docgen.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/docgen/lib/dart2yaml.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 30 chunks +1248 lines, -1065 lines 0 comments Download
A pkg/docgen/test/multi_library_test.dart View 1 chunk +174 lines, -0 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 3 chunks +19 lines, -32 lines 0 comments Download
M pkg/observe/lib/observe.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
6 years, 11 months ago (2014-01-14 18:30:47 UTC) #1
Alan Knight
lgtm, with the understanding there's more cleanup still coming, but we want to get this ...
6 years, 11 months ago (2014-01-14 18:32:34 UTC) #2
Emily Fortuna
6 years, 11 months ago (2014-01-14 18:34:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r31793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698