Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 13862003: dart:io | Add documentation changes to Link, File and Directory delete methods. (Closed)

Created:
7 years, 8 months ago by Bill Hesse
Modified:
7 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add documentation changes to Link, File and Directory delete methods. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21183

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M sdk/lib/io/directory.dart View 1 4 chunks +26 lines, -5 lines 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/io/link.dart View 1 5 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 8 months ago (2013-04-09 11:29:26 UTC) #1
Anders Johnsen
LGTM, thanks Bill! https://codereview.chromium.org/13862003/diff/1/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/13862003/diff/1/sdk/lib/io/directory.dart#newcode99 sdk/lib/io/directory.dart:99: * [delete] to be used to ...
7 years, 8 months ago (2013-04-09 16:34:35 UTC) #2
Bill Hesse
https://codereview.chromium.org/13862003/diff/1/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/13862003/diff/1/sdk/lib/io/directory.dart#newcode99 sdk/lib/io/directory.dart:99: * [delete] to be used to unconditionally delete the ...
7 years, 8 months ago (2013-04-10 08:07:07 UTC) #3
Bill Hesse
7 years, 8 months ago (2013-04-10 08:07:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698