Issue 13861024: Have dartdoc document exports.

Issue 13861024: Have dartdoc document exports. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Have dartdoc document exports. BUG=9651 Committed: https://code.google.com/p/dart/source/detail?r=21172

Patch Set 2 : Fixes on top of original commit #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1173 lines, -101 lines)			Patch
M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View	1	7 chunks	+37 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1	21 chunks	+244 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart	View		3 chunks	+85 lines, -3 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View	1	1 chunk	+342 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/pubspec.yaml	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/test/dartdoc_test.dart	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/export_map_test.dart	View		1 chunk	+400 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/utils_test.dart	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View		8 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

lgtm Also, are you sure that utils_test runs? https://codereview.chromium.org/13861024/diff/2001/sdk/lib/_internal/dartdoc/test/dartdoc_test.dart File sdk/lib/_internal/dartdoc/test/dartdoc_test.dart (right): https://codereview.chromium.org/13861024/diff/2001/sdk/lib/_internal/dartdoc/test/dartdoc_test.dart#newcode183 sdk/lib/_internal/dartdoc/test/dartdoc_test.dart:183: solo_test('file ...

7 years, 8 months ago (2013-04-09 20:06:14 UTC) #2

nweiz

I've tried making utils_test fail, and it does cause test.py to fail. https://codereview.chromium.org/13861024/diff/2001/sdk/lib/_internal/dartdoc/test/dartdoc_test.dart File sdk/lib/_internal/dartdoc/test/dartdoc_test.dart ...

7 years, 8 months ago (2013-04-09 20:09:53 UTC) #3

Andrei Mouravski

On 2013/04/09 20:09:53, nweiz wrote: > I've tried making utils_test fail, and it does cause ...

7 years, 8 months ago (2013-04-09 20:58:39 UTC) #4

nweiz

7 years, 8 months ago (2013-04-09 21:45:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r21172 (presubmit successful).

Expand Messages | Collapse Messages