Use the new test runner.

Use the new test runner.

R=lrn@google.com

Committed: https://github.com/dart-lang/typed_data/commit/caf61acf021c664b21de1ae06a15b84abb1dd46f

[nweiz, 2015-10-08 20:57:22]

nweiz@google.com changed reviewers:
+ lrn@google.com

[nweiz, 2015-10-08 20:57:22]

It looks like a bunch of the tests are failing on dart2js. I'm not sure which
ones should be marked as not intended for JS and which are legit bugs that
should be fixed.

[Lasse Reichstein Nielsen, 2015-10-09 06:22:25]

I'll try to have a look at the failures.

[Lasse Reichstein Nielsen, 2015-10-09 06:22:31]

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dart
File test/typed_buffers_test.dart (right):

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dar...
test/typed_buffers_test.dart:7: import "dart:typed_data";
I don't see any particular value in moving the dart import here.

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dar...
test/typed_buffers_test.dart:10: import "package:test/test.dart";
If you are reorganizing imports systematically (instead of "most important to
the file first", which is the current ordering), then maybe sort these
alphabetically.

[Lasse Reichstein Nielsen, 2015-10-09 10:24:09]

The only two errors I get with dart2js is the tests involving
Int64List/Uint64List, which are both not supported by dart2js (no 64 bit
integers anyway)

https://codereview.chromium.org/1385333007/diff/1/.test_config
File .test_config (right):

https://codereview.chromium.org/1385333007/diff/1/.test_config#newcode1
.test_config:1: {
Trailing whitespace here.

[Lasse Reichstein Nielsen, 2015-10-09 10:24:28]

LGTM

[nweiz, 2015-10-13 19:51:13]

Code review changes

[nweiz, 2015-10-13 19:51:40]

> The only two errors I get with dart2js is the tests involving
Int64List/Uint64List, which are both not supported by dart2js (no 64 bit
integers anyway)

It looks like the other errors are specific to phantomjs, which means they're
probably on Safari as well. I'll mark the 64-bit tests as VM-only, but it's
probably worth looking deeper into the other failures.

https://codereview.chromium.org/1385333007/diff/1/.test_config
File .test_config (right):

https://codereview.chromium.org/1385333007/diff/1/.test_config#newcode1
.test_config:1: {
On 2015/10/09 10:24:09, Lasse Reichstein Nielsen wrote:
> Trailing whitespace here.

Done.

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dart
File test/typed_buffers_test.dart (right):

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dar...
test/typed_buffers_test.dart:7: import "dart:typed_data";
On 2015/10/09 06:22:31, Lasse Reichstein Nielsen wrote:
> I don't see any particular value in moving the dart import here.

It's very consistent with other packages to put dart: imports before package:
imports before relative imports, and Bob tells me it's part of the new style
guide that he's working on now.

https://codereview.chromium.org/1385333007/diff/1/test/typed_buffers_test.dar...
test/typed_buffers_test.dart:10: import "package:test/test.dart";
On 2015/10/09 06:22:30, Lasse Reichstein Nielsen wrote:
> If you are reorganizing imports systematically (instead of "most important to
> the file first", which is the current ordering), then maybe sort these
> alphabetically.

Done.

[nweiz, 2015-10-13 19:51:50]

Committed patchset #2 (id:20001) manually as
caf61acf021c664b21de1ae06a15b84abb1dd46f (presubmit successful).