Issue 13852044: Fix performance of parsing Mints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13852044: Fix performance of parsing Mints. (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix performance of parsing Mints. Committed: https://code.google.com/p/dart/source/detail?r=21767

Patch Set 4 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	runtime/lib/integers.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	runtime/platform/c99_support_win.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/13852044/diff/4001/runtime/lib/integers.cc File runtime/lib/integers.cc (right): https://codereview.chromium.org/13852044/diff/4001/runtime/lib/integers.cc#newcode186 runtime/lib/integers.cc:186: #endif Could you move this to platform/c99_support_win.h

7 years, 8 months ago (2013-04-19 20:04:36 UTC) #3

srdjan

https://codereview.chromium.org/13852044/diff/4001/runtime/lib/integers.cc File runtime/lib/integers.cc (right): https://codereview.chromium.org/13852044/diff/4001/runtime/lib/integers.cc#newcode186 runtime/lib/integers.cc:186: #endif On 2013/04/19 20:04:36, siva wrote: > Could you ...

7 years, 8 months ago (2013-04-19 20:06:53 UTC) #4

srdjan

7 years, 8 months ago (2013-04-19 20:22:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r21767 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13852044: Fix performance of parsing Mints. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages