Issue 13852043: unittest: testCases back to being UnmodifiableListView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13852043: unittest: testCases back to being UnmodifiableListView (Closed)

Created:
7 years, 8 months ago by kevmoo-old

Modified:
7 years, 8 months ago

Reviewers:
gram

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

unittest: testCases back to being UnmodifiableListView There is a bug in the new analyzer which reports this not being List. Committed: https://code.google.com/p/dart/source/detail?r=21769

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	pkg/unittest/lib/unittest.dart	View	1 2	4 chunks	+9 lines, -7 lines	0 comments	Download
	M	pkg/unittest/test/unittest_test.dart	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

kevmoo-old

The fact that testCases is showing up as NOT List is an analyzer bug. We ...

7 years, 8 months ago (2013-04-19 18:27:53 UTC) #1

nweiz

I don't know that I like using UnmodifiableListView until the analyzer bug is fixed... is ...

7 years, 8 months ago (2013-04-19 18:39:52 UTC) #2

gram

lgtm, but please do not submit this until the analyzer issue is fixed.

7 years, 8 months ago (2013-04-19 18:52:44 UTC) #3

kevmoo-old

7 years, 8 months ago (2013-04-19 20:42:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21769 (presubmit successful).