Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13852015: unhide nodeType constants (Closed)

Created:
7 years, 8 months ago by Jennifer Messerly
Modified:
7 years, 8 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

unhide nodeType constants Node.nodeType is not very useful without these :) See also: https://code.google.com/p/dart/issues/detail?id=4754 Committed: https://code.google.com/p/dart/source/detail?r=21840

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merged #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
Not sure what happened here; git blame only took me back to a change Andrei ...
7 years, 8 months ago (2013-04-18 22:34:31 UTC) #1
blois
lgtm
7 years, 8 months ago (2013-04-19 00:36:05 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/13852015/diff/5001/sdk/lib/web_audio/dartium/web_audio_dartium.dart File sdk/lib/web_audio/dartium/web_audio_dartium.dart (right): https://codereview.chromium.org/13852015/diff/5001/sdk/lib/web_audio/dartium/web_audio_dartium.dart#newcode9 sdk/lib/web_audio/dartium/web_audio_dartium.dart:9: import 'dart:typeddata'; this happened when I reran ./go.sh after ...
7 years, 8 months ago (2013-04-22 18:56:29 UTC) #3
blois
https://codereview.chromium.org/13852015/diff/5001/sdk/lib/web_audio/dartium/web_audio_dartium.dart File sdk/lib/web_audio/dartium/web_audio_dartium.dart (right): https://codereview.chromium.org/13852015/diff/5001/sdk/lib/web_audio/dartium/web_audio_dartium.dart#newcode9 sdk/lib/web_audio/dartium/web_audio_dartium.dart:9: import 'dart:typeddata'; On 2013/04/22 18:56:29, John Messerly wrote: > ...
7 years, 8 months ago (2013-04-22 19:26:44 UTC) #4
Jennifer Messerly
7 years, 8 months ago (2013-04-22 21:30:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r21840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698