Make mock behaviors be ordered.

Make mock behaviors be ordered.
See https://code.google.com/p/dart/issues/detail?id=8950

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22191

[Siggi Cherem (dart-lang), 2013-04-30 03:25:31]

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/lib/mock.dart
File pkg/unittest/lib/mock.dart (right):

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/lib/mock.dart#ne...
pkg/unittest/lib/mock.dart:1269: _behaviorIndices = new Map<String,int>();
what about using LinkedHashMap instead of Map?

That should take care of iterating things in the order in which they are added
=)

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/test/mock_test.dart
File pkg/unittest/test/mock_test.dart (right):

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/test/mock_test.d...
pkg/unittest/test/mock_test.dart:668: //
m.when(...).thenReturn(1).thenrReturn(2)
thenrReturn => thenReturn

[gram, 2013-04-30 16:53:39]

PTAL

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/lib/mock.dart
File pkg/unittest/lib/mock.dart (right):

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/lib/mock.dart#ne...
pkg/unittest/lib/mock.dart:1269: _behaviorIndices = new Map<String,int>();
On 2013/04/30 03:25:31, Siggi Cherem (dart-lang) wrote:
> what about using LinkedHashMap instead of Map?
> 
> That should take care of iterating things in the order in which they are added
> =)

Done.

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/test/mock_test.dart
File pkg/unittest/test/mock_test.dart (right):

https://codereview.chromium.org/13851022/diff/1/pkg/unittest/test/mock_test.d...
pkg/unittest/test/mock_test.dart:668: //
m.when(...).thenReturn(1).thenrReturn(2)
On 2013/04/30 03:25:31, Siggi Cherem (dart-lang) wrote:
> thenrReturn => thenReturn

Done.

[Siggi Cherem (dart-lang), 2013-04-30 18:14:40]

lgtm! yay!

[gram, 2013-04-30 18:15:42]

Committed patchset #3 manually as r22191 (presubmit successful).