Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1384473002: Remove hints in build of try (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove hints in build of try Closes #24470 and #24435 This doesn't fix the underlying (but unreported!) errors. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/2888b210a44db3b29b54775b795114cfeaa61d24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M site/try/src/leap.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-10-01 09:44:52 UTC) #2
Bill Hesse
lgtm
5 years, 2 months ago (2015-10-01 10:10:34 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-01 11:32:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2888b210a44db3b29b54775b795114cfeaa61d24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698