Adjust assertions in MethodMirror.source not to expect source for implicit constructors or signatur…

Adjust assertions in MethodMirror.source not to expect source for implicit constructors or signature functions.

BUG=http://dartbug.com/16588
R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32454

[hausner, 2014-02-07 21:07:58]

LGTM with comment.

https://codereview.chromium.org/138383007/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/138383007/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:2040: if (func.IsImplicitConstructor() ||
func.IsSignatureFunction()) {
There may be other cases of functions that have no source code. I can think of
the forwarding constructors that are inserted in mixin application classes, or
implicit getter and setter functions, method extractor functions, no such method
dispatcher. Can these functions appear here?

[rmacnak, 2014-02-07 21:28:45]

https://codereview.chromium.org/138383007/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/138383007/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:2040: if (func.IsImplicitConstructor() ||
func.IsSignatureFunction()) {
On 2014/02/07 21:07:58, hausner wrote:
> There may be other cases of functions that have no source code. I can think of
> the forwarding constructors that are inserted in mixin application classes,

Now it is considered an implicit constructor. Leaving a note that that might
change when the restrictions on mixins are relaxed.

> implicit getter and setter functions, method extractor functions, no such
method
> dispatcher. Can these functions appear here?

No, we don't hand out mirrors on these.

[rmacnak, 2014-02-07 21:46:06]

Committed patchset #2 manually as r32454 (presubmit successful).