Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1383713002: Free copy of hostname in SecureSocket implementation. (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Free copy of hostname in SecureSocket implementation. BUG=https://github.com/dart-lang/sdk/issues/24186 BUG=https://github.com/dart-lang/sdk/issues/24225 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/e5ebc9c630e4d2aced6fcc873269b34802cefc7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M runtime/bin/secure_socket.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 2 months ago (2015-10-01 11:18:15 UTC) #2
Søren Gjesse
lgtm
5 years, 2 months ago (2015-10-01 12:53:13 UTC) #3
Bill Hesse
5 years, 2 months ago (2015-10-01 15:28:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5ebc9c630e4d2aced6fcc873269b34802cefc7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698