Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 138303005: Remove non existent paths from the analyze_library suite and add bugs for all other entries (Closed)

Created:
6 years, 10 months ago by ricow1
Modified:
6 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove non existent paths from the analyze_library suite and add bugs for all other entries R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32273

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 2 1 chunk +28 lines, -31 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 10 months ago (2014-02-04 08:22:31 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/138303005/diff/50001/tests/lib/analyzer/analyze_library.status File tests/lib/analyzer/analyze_library.status (right): https://codereview.chromium.org/138303005/diff/50001/tests/lib/analyzer/analyze_library.status#newcode25 tests/lib/analyzer/analyze_library.status:25: lib/_internal/pub/lib/src/command: Pass, CompileTimeError # Pass necessary, since CompileTimeError ...
6 years, 10 months ago (2014-02-04 08:27:49 UTC) #2
ricow1
https://codereview.chromium.org/138303005/diff/50001/tests/lib/analyzer/analyze_library.status File tests/lib/analyzer/analyze_library.status (right): https://codereview.chromium.org/138303005/diff/50001/tests/lib/analyzer/analyze_library.status#newcode25 tests/lib/analyzer/analyze_library.status:25: lib/_internal/pub/lib/src/command: Pass, CompileTimeError # Pass necessary, since CompileTimeError is ...
6 years, 10 months ago (2014-02-04 09:00:31 UTC) #3
ricow1
6 years, 10 months ago (2014-02-04 09:00:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r32273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698