Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1382603002: dart2js: provide a better error-message, when a backend doesn't support mirrors. (Closed)

Created:
5 years, 2 months ago by floitsch
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: provide a better error-message, when a backend doesn't support mirrors. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/773cb94c9846008bd750e5fc2fed4258294ca29c

Patch Set 1 #

Patch Set 2 : Refactor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +16 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 2 months ago (2015-09-30 12:42:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 2 months ago (2015-09-30 17:09:44 UTC) #3
floitsch
5 years, 2 months ago (2015-09-30 17:52:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
773cb94c9846008bd750e5fc2fed4258294ca29c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698