Issue 13820004: Fixing SVGPaint constructor DartC error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13820004: Fixing SVGPaint constructor DartC error. (Closed)

Created:
7 years, 8 months ago by blois

Modified:
7 years, 8 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing SVGPaint constructor DartC error. Had removed the constructor because it was no longer needed to call the base class, but it's actually needed for derived classes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21127

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -0 lines)			Patch
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_SVGColor.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r21127 (presubmit successful).

7 years, 8 months ago (2013-04-09 00:42:11 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages