Issue 13818010: dart:io | Ensure that Directory.list terminates even when symbolic links create loops in the file s…

Issue 13818010: dart:io | Ensure that Directory.list terminates even when symbolic links create loops in the file s… (Closed)

Created:
7 years, 8 months ago by Bill Hesse

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Ensure that Directory.list terminates even when symbolic links create loops in the file system. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21199

Patch Set 2 : Add Windows implementation #

Patch Set 3 : Fix windows bugs #

Patch Set 4 : Add documentation of new behavior. #

Total comments: 5

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+280 lines, -36 lines)			Patch
M	runtime/bin/directory_android.cc	View		6 chunks	+60 lines, -10 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View		7 chunks	+61 lines, -10 lines	2 comments	Download
M	runtime/bin/directory_macos.cc	View		6 chunks	+60 lines, -10 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1 2	9 chunks	+62 lines, -4 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View	1 2 3	2 chunks	+10 lines, -2 lines	0 comments	Download
M	tests/standalone/io/link_test.dart	View		1 chunk	+27 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM https://codereview.chromium.org/13818010/diff/7001/runtime/bin/directory_linux.cc File runtime/bin/directory_linux.cc (right): https://codereview.chromium.org/13818010/diff/7001/runtime/bin/directory_linux.cc#newcode199 runtime/bin/directory_linux.cc:199: previous->ino == current_link.ino) { How about adding a ...

7 years, 8 months ago (2013-04-10 11:33:23 UTC) #2

Bill Hesse

https://codereview.chromium.org/13818010/diff/7001/runtime/bin/directory_linux.cc File runtime/bin/directory_linux.cc (right): https://codereview.chromium.org/13818010/diff/7001/runtime/bin/directory_linux.cc#newcode199 runtime/bin/directory_linux.cc:199: previous->ino == current_link.ino) { On 2013/04/10 11:33:23, Søren Gjesse ...

7 years, 8 months ago (2013-04-10 12:49:47 UTC) #3

Bill Hesse

7 years, 8 months ago (2013-04-10 13:07:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r21199 (presubmit successful).

Expand Messages | Collapse Messages