Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138163006: Add top-level server (Closed)

Created:
6 years, 11 months ago by Brian Wilkerson
Modified:
6 years, 11 months ago
Reviewers:
devoncarew, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -0 lines) Patch
A pkg/analysis_server/lib/server.dart View 1 chunk +13 lines, -0 lines 2 comments Download
A pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +156 lines, -0 lines 1 comment Download
A pkg/analysis_server/lib/src/http_server.dart View 1 chunk +182 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Brian Wilkerson
6 years, 11 months ago (2014-01-21 15:53:43 UTC) #1
devoncarew
lgtm https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/server.dart File pkg/analysis_server/lib/server.dart (right): https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/server.dart#newcode10 pkg/analysis_server/lib/server.dart:10: void main(List<String> args) { You probably want to ...
6 years, 11 months ago (2014-01-21 20:59:27 UTC) #2
danrubel
lgtm https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/src/http_server.dart File pkg/analysis_server/lib/src/http_server.dart (right): https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/src/http_server.dart#newcode22 pkg/analysis_server/lib/src/http_server.dart:22: class HttpAnalysisServer { Consider moving this to /lib ...
6 years, 11 months ago (2014-01-21 22:36:27 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/server.dart File pkg/analysis_server/lib/server.dart (right): https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/server.dart#newcode10 pkg/analysis_server/lib/server.dart:10: void main(List<String> args) { Done https://codereview.chromium.org/138163006/diff/1/pkg/analysis_server/lib/src/http_server.dart File pkg/analysis_server/lib/src/http_server.dart (right): ...
6 years, 11 months ago (2014-01-22 01:05:49 UTC) #4
Brian Wilkerson
6 years, 11 months ago (2014-01-25 18:46:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r32008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698