Don't try to measure the running time if the test hasn't started yet.

Don't try to measure the running time if the test hasn't started yet.

Committed: https://code.google.com/p/dart/source/detail?r=21163

[floitsch, 2013-04-09 17:01:11]

On some failing tests the framework would otherwise report a null pointer error
instead of the stacktrace of the actual error.

[Bob Nystrom, 2013-04-09 18:14:46]

Adding Gram as a reviewer...

This change seems weird to me. The existence of the bug you're seeing implies to
me that an invariant might not be correctly maintained. Is it valid to complete
a test that was never correctly prepped? Will this confuse certain test
configurations?

[floitsch, 2013-04-09 18:23:06]

On 2013/04/09 18:14:46, Bob Nystrom wrote:
> Adding Gram as a reviewer...
> 
> This change seems weird to me. The existence of the bug you're seeing implies
to
> me that an invariant might not be correctly maintained. Is it valid to
complete
> a test that was never correctly prepped? Will this confuse certain test
> configurations?

I'm not really attached to this CL. If you have a better solution let me know
and I close this CL.

Here is the diff that triggered the bad error-message.

diff --git a/utils/tests/pub/error_group_test.dart
b/utils/tests/pub/error_group_test.dart
index e7aa477..8876cb7 100644
--- a/utils/tests/pub/error_group_test.dart
+++ b/utils/tests/pub/error_group_test.dart
@@ -204,7 +204,7 @@ main() {
     setUp(() {
       errorGroup = new ErrorGroup();
       controller = new StreamController.broadcast();
-      stream = errorGroup.registerStream(controller.stream);
+      stream = errorGroup.registerStream(controller.stream.asBroadcast());
     });
 
     test('should pass through values from the stream', () {
@@ -344,8 +344,8 @@ main() {
       errorGroup = new ErrorGroup();
       controller1 = new StreamController.broadcast();
       controller2 = new StreamController.broadcast();
-      stream1 = errorGroup.registerStream(controller1.stream);
-      stream2 = errorGroup.registerStream(controller2.stream);
+      stream1 = errorGroup.registerStream(controller1.stream.asBroadcast());
+      stream2 = errorGroup.registerStream(controller2.stream.asBroadcast());
     });
 
     test("should pipe exceptions from one stream to the other and to .done",
@@ -398,7 +398,7 @@ main() {
     setUp(() {
       errorGroup = new ErrorGroup();
       controller = new StreamController.broadcast();
-      stream = errorGroup.registerStream(controller.stream);
+      stream = errorGroup.registerStream(controller.stream.asBroadcast());
       completer = new Completer();
       future = errorGroup.registerFuture(completer.future);
     });

[floitsch, 2013-04-09 19:06:01]

Added comment.

[gram, 2013-04-09 19:08:04]

lgtm

[floitsch, 2013-04-09 19:09:43]

Committed patchset #2 manually as r21163 (presubmit successful).