Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 13812019: Fix arguments to dart2js in windows bat file (Closed)

Created:
7 years, 8 months ago by ricow1
Modified:
7 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix arguments to dart2js in windows bat file Wrongly assigned the library path to vm options Committed: https://code.google.com/p/dart/source/detail?r=21248

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/bin/dart2js.bat View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 8 months ago (2013-04-11 06:15:38 UTC) #1
ricow1
TBR
7 years, 8 months ago (2013-04-11 06:16:40 UTC) #2
ricow1
Committed patchset #1 manually as r21248 (presubmit successful).
7 years, 8 months ago (2013-04-11 06:16:51 UTC) #3
ahe
7 years, 8 months ago (2013-04-11 07:07:01 UTC) #4
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/13812019/diff/1/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://codereview.chromium.org/13812019/diff/1/sdk/bin/dart2js.bat#newcode30
sdk/bin/dart2js.bat:30: set EXTRA_OPTIONS=%EXTRA_OPTIONS%
--library-root=%SDK_DIR%
Quotes around %SDK_DIR%?

Powered by Google App Engine
This is Rietveld 408576698