Update code generator for dartium dart:html with typeddata.

Update code generator for dartium dart:html with typeddata.

R=antonm@google.com, vsm@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21790

[Mads Ager (google), 2013-04-18 11:28:42]

Does the [Custom] declaration in dart.idl that I'm introducing here have any
influence on dart2js code generation?

[Anton Muhin, 2013-04-18 16:13:40]

There should be more to clean up, but we may wait.

LGTM

https://codereview.chromium.org/13811054/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/13811054/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:6: [Custom] void decodeAudioData(in ArrayBuffer
audioData, in AudioBufferCallback successCallback, in AudioBufferCallback
errorCallback)
please, TODO that those custom methods should be autogenerated.

https://codereview.chromium.org/13811054/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:10: [ Supplemental ]
nit: no spaces around Supplemental.

[vsm, 2013-04-18 16:18:27]

LGTM.

The custom idl shouldn't affect dart2js gen.

[Mads Ager (google), 2013-04-19 11:15:24]

Had to change this to match Vijay's latest patch. The code generator now
generates the dartium conversions directly through DartUtilities.

[Anton Muhin, 2013-04-19 11:37:53]

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1341: conversion_cast =
'static_cast<ArrayBufferView*>(%s)' % value
do you need this cast?

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1354: return []
why no includes?

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1357: conversion_cast = 'static_cast<%s*>(%s)' %
(self.native_type(), value)
why you need a cast?

[Mads Ager (google), 2013-04-19 12:05:41]

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1341: conversion_cast =
'static_cast<ArrayBufferView*>(%s)' % value
On 2013/04/19 11:37:53, Anton Muhin wrote:
> do you need this cast?

Ehm, no. Thanks!

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1354: return []
On 2013/04/19 11:37:53, Anton Muhin wrote:
> why no includes?

Because it only needs DartUtilities. Am I missing something? It builds with no
includes.

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1357: conversion_cast = 'static_cast<%s*>(%s)' %
(self.native_type(), value)
On 2013/04/19 11:37:53, Anton Muhin wrote:
> why you need a cast?

Ehm, no. Thanks! :-)

[Anton Muhin, 2013-04-19 12:57:43]

Still LGTM

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13811054/diff/6001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:1354: return []
Adding includes might be more robust, but we are not consistent here anyway, so
up to you.

On 2013/04/19 12:05:41, Mads Ager wrote:
> On 2013/04/19 11:37:53, Anton Muhin wrote:
> > why no includes?
> 
> Because it only needs DartUtilities. Am I missing something? It builds with no
> includes.

[Mads Ager (google), 2013-04-22 08:24:51]

Committed patchset #3 manually as r21790 (presubmit successful).