Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 13811019: Move IterableMixinWorkaround to internal library. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 8 months ago
Reviewers:
floitsch, blois
CC:
reviews_dartlang.org, blois
Visibility:
Public.

Description

Move IterableMixinWorkaround to internal library. From here we can remove it in stages after M4 without risking breaking the VM, dart2js or the HTML library right now. Committed: https://code.google.com/p/dart/source/detail?r=21443

Patch Set 1 #

Patch Set 2 : Merge to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -324 lines) Patch
M sdk/lib/_collection_dev/iterable.dart View 1 2 chunks +323 lines, -1 line 0 comments Download
M sdk/lib/collection/collections.dart View 1 1 chunk +0 lines, -323 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-09 14:25:15 UTC) #1
floitsch
LGTM. Added Pete. For Pete's information: we are planning to replace the IterableMixinWorkaround calls with ...
7 years, 8 months ago (2013-04-09 14:31:28 UTC) #2
blois
lgtm
7 years, 8 months ago (2013-04-09 16:15:09 UTC) #3
kevmoo-old
DBQ: What is IterableMixinWorkaround doing that's it's still needed in the dom classes vs the ...
7 years, 8 months ago (2013-04-09 19:33:22 UTC) #4
Lasse Reichstein Nielsen
We just haven't gotten around to removing all the uses in the HTML library yet. ...
7 years, 8 months ago (2013-04-11 15:15:28 UTC) #5
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-15 12:35:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r21443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698