Issue 138003019: Fix for bug 14923

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138003019: Fix for bug 14923 (Closed)

Created:
6 years, 10 months ago by blois

Modified:
6 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix for bug 14923 Make sure that completeError is not called with null. BUG=14923 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=34797

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -23 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	2 chunks	+14 lines, -11 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	2 chunks	+14 lines, -8 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	2 chunks	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_AudioContext.darttemplate	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

6 years, 8 months ago (2014-04-07 21:21:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34797 (presubmit successful).