Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 13800002: dart:io | Add asynchronous Link.create implementation. (Closed)

Created:
7 years, 8 months ago by Bill Hesse
Modified:
7 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add asynchronous Link.create implementation. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M runtime/bin/file.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file.cc View 3 chunks +20 lines, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 8 months ago (2013-04-08 14:48:42 UTC) #1
Anders Johnsen
LGTM, do we have a test?
7 years, 8 months ago (2013-04-08 14:51:28 UTC) #2
Bill Hesse
On 2013/04/08 14:51:28, Anders Johnsen wrote: > LGTM, do we have a test? Yes, all ...
7 years, 8 months ago (2013-04-08 15:01:44 UTC) #3
Bill Hesse
7 years, 8 months ago (2013-04-08 15:12:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698