Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 1379743002: Remove checked mode instrinsic for _List.[]=. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove checked mode instrinsic for _List.[]= from the precompilation architectures. BUG=http://dartbug.com/24336 R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/7b0937f5241df0867d9d06a22986d4fd4606f381

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -133 lines) Patch
M runtime/vm/intrinsifier_arm.cc View 1 1 chunk +3 lines, -45 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 1 chunk +3 lines, -45 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 1 chunk +3 lines, -42 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-09-30 01:02:53 UTC) #2
srdjan
lgtm
5 years, 2 months ago (2015-09-30 05:44:13 UTC) #3
rmacnak
5 years, 2 months ago (2015-09-30 17:24:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7b0937f5241df0867d9d06a22986d4fd4606f381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698