HttpSession: better toString()

HttpSession: better toString()

R=ajohnsen@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32044

[kevmoo, 2014-01-20 23:27:59]

Also added a couple of voids to methods, trimmed some trailing spaces.

[Anders Johnsen, 2014-01-27 08:32:51]

lgtm, I think this makes sense... Maybe write something in front, like: 

String toString() => "HttpSession($_data)";

?

[Søren Gjesse, 2014-01-27 15:31:02]

lgtm

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/http_session.dart
File sdk/lib/io/http_session.dart (right):

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/http_session.dart...
sdk/lib/io/http_session.dart:64: String toString() => _data.toString();
As Anders mentioned we add the class name, e.g. "HttpSession: $_data". And maybe
add the session ID as well.

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/io.dart
File sdk/lib/io/io.dart (right):

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/io.dart#newcode85
sdk/lib/io/io.dart:85: * process while it is running. Using `run()` returns a
Future, which completes with
Maybe fix the long line when as well.

[kevmoo, 2014-01-28 00:08:44]

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/http_session.dart
File sdk/lib/io/http_session.dart (right):

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/http_session.dart...
sdk/lib/io/http_session.dart:64: String toString() => _data.toString();
On 2014/01/27 15:31:03, Søren Gjesse wrote:
> As Anders mentioned we add the class name, e.g. "HttpSession: $_data". And
maybe
> add the session ID as well.

Done.

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/io.dart
File sdk/lib/io/io.dart (right):

https://codereview.chromium.org/137953005/diff/1/sdk/lib/io/io.dart#newcode85
sdk/lib/io/io.dart:85: * process while it is running. Using `run()` returns a
Future, which completes with
On 2014/01/27 15:31:03, Søren Gjesse wrote:
> Maybe fix the long line when as well.

Done.

[kevmoo, 2014-01-28 00:09:20]

Committed patchset #2 manually as r32044 (presubmit successful).